Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tk] Expose dtypes #393

Merged
merged 8 commits into from
Feb 5, 2024
Merged

[tk] Expose dtypes #393

merged 8 commits into from
Feb 5, 2024

Conversation

Groverkss
Copy link
Contributor

@Groverkss Groverkss commented Feb 5, 2024 •
edited
Loading

This patch exposes data types to users. Currently, creation of constant vectors for expoxed types is supported and arithmetic on them.

What is not supported yet:

  1. Scalar conversion
  2. Vector conversion
  3. KernelBuffer element type
  4. Promotion/Truncation

Test output: https://gist.github.com/Groverkss/30d5aaad0ea2b44960ba88b5340463ad

@Groverkss Groverkss marked this pull request as ready for review February 5, 2024 05:01
stellaraccident
stellaraccident approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@stellaraccident stellaraccident left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like this. I think the conversion rules as you have them is sensible for this level.

@Groverkss Groverkss merged commit 0bb2a8c into nod-ai:main Feb 5, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stellaraccident stellaraccident stellaraccident approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Groverkss @stellaraccident