Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstreaming MLPerf punet changes, server/harness support. #799

Open
wants to merge 92 commits into
base: main
Choose a base branch
from
Open

Upstreaming MLPerf punet changes, server/harness support. #799

wants to merge 92 commits into from

Commits on Jul 16, 2024

  1. Bump punet revision to d30d6ff

    @eagarvey-amd @saienduri
    eagarvey-amd authored and saienduri committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a3376d9 View commit details
    Browse the repository at this point in the history

  2. Enable punet t2i test.

    @eagarvey-amd @saienduri
    eagarvey-amd authored and saienduri committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7cabac0 View commit details
    Browse the repository at this point in the history

  3. Use formatted strings as input to printer.

    @eagarvey-amd @saienduri
    eagarvey-amd authored and saienduri committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7dfd4c8 View commit details
    Browse the repository at this point in the history

  4. Rework sdxl test to setup with a pipeline, fix unloading submodels, f… 

    …actor out punet setup from pipe init
    @eagarvey-amd @saienduri
    eagarvey-amd authored and saienduri committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    1cd3ee9 View commit details
    Browse the repository at this point in the history

  5. Add switch for punet preprocessing flags

    @eagarvey-amd @saienduri
    eagarvey-amd authored and saienduri committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    1a90abd View commit details
    Browse the repository at this point in the history

  6. Xfail punet e2e test.

    @eagarvey-amd @saienduri
    eagarvey-amd authored and saienduri committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    b70318d View commit details
    Browse the repository at this point in the history

  7. Fixups to sdxl test arguments

    @eagarvey-amd @saienduri
    eagarvey-amd authored and saienduri committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    2d7ebcd View commit details
    Browse the repository at this point in the history

  8. Fix flagset arg and enable vae encode.

    @eagarvey-amd @saienduri
    eagarvey-amd authored and saienduri committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    feebc87 View commit details
    Browse the repository at this point in the history

  9. Enable VAE encode validation, mark as xfail

    @eagarvey-amd @saienduri
    eagarvey-amd authored and saienduri committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    af7782b View commit details
    Browse the repository at this point in the history

  10. Fix formatting

    @eagarvey-amd @saienduri
    eagarvey-amd authored and saienduri committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    eff59a9 View commit details
    Browse the repository at this point in the history

  11. fix runner function name in old sd test.

    @eagarvey-amd @saienduri
    eagarvey-amd authored and saienduri committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    63fb053 View commit details
    Browse the repository at this point in the history

  12. Fix xfail syntax.

    @eagarvey-amd @saienduri
    eagarvey-amd authored and saienduri committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    aff48ab View commit details
    Browse the repository at this point in the history

  13. Update unet script for compile function signature change

    @eagarvey-amd @saienduri
    eagarvey-amd authored and saienduri committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    b10ad8d View commit details
    Browse the repository at this point in the history

  14. Update punet to 4d4f955

    @IanNod @saienduri
    IanNod authored and saienduri committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    321d21d View commit details
    Browse the repository at this point in the history

  15. Disable vulkan test on MI250 runner.

    @monorimet @saienduri
    monorimet authored and saienduri committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    2de912e View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Change tqdm disable conditions and deepcopy model map on init.

    @eagarvey-amd
    eagarvey-amd committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    9fdc07f View commit details
    Browse the repository at this point in the history

  2. Don't break workarounds for model path 

    Too many regressions based on workarounds for problems that are now fixed. Until submission just accept all cases.
    @monorimet
    monorimet authored Jul 17, 2024
    Configuration menu
    Copy the full SHA
    b20be32 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Fix for passing a path as attn_spec.

    @eagarvey-amd
    eagarvey-amd committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    02705a9 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Bump punet revision to defeb489fe2bb17b77d587924db9e58048a8c140

    @eagarvey-amd
    eagarvey-amd committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    9229aed View commit details
    Browse the repository at this point in the history

  2. Move JIT cpu scheduling load helpers inside conditional.

    @eagarvey-amd
    eagarvey-amd committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    f09ef4a View commit details
    Browse the repository at this point in the history

  3. formatting

    @eagarvey-amd
    eagarvey-amd committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    bbcc424 View commit details
    Browse the repository at this point in the history

  4. Don't pass benchmark as an export arg.

    @eagarvey-amd
    eagarvey-amd committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    1f19c7f View commit details
    Browse the repository at this point in the history

  5. Changes so no external downloads. (#781)

    @saienduri
    saienduri authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    39c0c00 View commit details
    Browse the repository at this point in the history

  6. fix so that we check exact paths as well for is_prepared (#782)

    @saienduri
    saienduri authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    3c59b25 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2024

  1. Update punet to 60edc91

    @IanNod
    IanNod authored Jul 20, 2024
    Configuration menu
    Copy the full SHA
    2e9de46 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2024

  1. Vae weight path none check (#784)

    @saienduri
    saienduri authored Jul 21, 2024
    Configuration menu
    Copy the full SHA
    aa0ac2b View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Bump punet to mi300_all_sym_8_step10 (62785ea)

    @monorimet
    monorimet authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    6556a36 View commit details
    Browse the repository at this point in the history

  2. Changes so that the default run without quant docker will work as wel… 

    …l with all the new changes. (#785)

This PR makes the necessary changes so that you don't have to run the
quantization docker to run the normal harness. With stricter checks for
the quant paths and adding a special switch to the save_external_weights
so that it is compliant with this change that we need for the docker
generated weights
iree-org/iree-turbine@cd916ec.
    @saienduri
    saienduri authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    2c49cb6 View commit details
    Browse the repository at this point in the history

  3. Bump punet to 361df65844e0a7c766484707c57f6248cea9587f

    @eagarvey-amd
    eagarvey-amd committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    cb911b1 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Sync flags to sdxl-scripts repo (#786) 

    Sync flags to sdxl-scripts repo
    @saienduri
    saienduri authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    d857f77 View commit details
    Browse the repository at this point in the history

  2. Integrate int8 tk kernels (#783)

    @nithinsubbiah
    nithinsubbiah authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    37548f2 View commit details
    Browse the repository at this point in the history

  3. Update punet revision to deterministic version (42e9407) 

    Bumps punet revision --  https://huggingface.co/amd-shark/sdxl-quant-models/commit/42e94070478ed0599c0225a4879b69b253206eb6
    @monorimet
    monorimet authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    25b2462 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Integration of tk kernels into pipeline (#789) 

    Currently using a link, but Nithin will be pushing the fix to use a file
name asap
    @saienduri
    saienduri authored Jul 24, 2024
    Configuration menu
    Copy the full SHA
    0e57b4e View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Update unet horizontal fusion flag (#790)

    @saienduri
    saienduri authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    920dbf5 View commit details
    Browse the repository at this point in the history

  2. Revert "Update unet horizontal fusion flag (#790)" 

    This reverts commit 920dbf5.
    @saienduri
    saienduri committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    6f16731 View commit details
    Browse the repository at this point in the history

  3. [tk kernel] Add support to match kernel with number of arguments and … 

    …update kernel links (#791)
    @nithinsubbiah
    nithinsubbiah authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    15dbd93 View commit details
    Browse the repository at this point in the history

  4. Add functionality to SD pipeline and abstracted components for saving… 

    … output .npys (#792)
    @monorimet
    monorimet authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    0c02652 View commit details
    Browse the repository at this point in the history

  5. Remove download links for tk kernels and instead specify kernel direc… 

    …tory as an argument (#793)
    @nithinsubbiah
    nithinsubbiah authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    3fd954b View commit details
    Browse the repository at this point in the history

  6. Update to best iteration on unet weights (#794)

    @saienduri
    saienduri authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    7f8a2b0 View commit details
    Browse the repository at this point in the history

  7. Add missing tk_kernel_args arg in function calls (#795)

    @nithinsubbiah
    nithinsubbiah authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    bf63aec View commit details
    Browse the repository at this point in the history

  8. update hash for config file

    @saienduri
    saienduri authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    a74d98e View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Fix formatting

    @eagarvey-amd
    eagarvey-amd committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    925cd0c View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Point to sdxl-vae-fix branch of iree-turbine.

    @eagarvey-amd
    eagarvey-amd committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    7715fd0 View commit details
    Browse the repository at this point in the history

  2. Add SD3 to sd_pipeline

    @eagarvey-amd
    eagarvey-amd committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    e276c78 View commit details
    Browse the repository at this point in the history

  3. Update test_models.yml 

    CPU runs take up to a minute, so only do two steps to validate in CI.
    @monorimet
    monorimet authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    de5d3de View commit details
    Browse the repository at this point in the history

  4. Remove default in mmdit export args.

    @eagarvey-amd
    eagarvey-amd committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    d0d3ae6 View commit details
    Browse the repository at this point in the history

  5. set vae_harness to False in sdxl test.

    @eagarvey-amd
    eagarvey-amd committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    403fe47 View commit details
    Browse the repository at this point in the history

  6. Switch to main branch of iree-turbine

    @eagarvey-amd
    eagarvey-amd committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    0ac6b64 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Update sd3_vae.py

    @monorimet
    monorimet authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    1a41394 View commit details
    Browse the repository at this point in the history

  2. Remove preprocess arg that fails to parse.

    @monorimet
    monorimet authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    493f260 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. SD3 updates, CLI arguments for multi-device

    @eagarvey-amd
    eagarvey-amd committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    711403c View commit details
    Browse the repository at this point in the history

  2. Tweaks to requirements, scheduler filenames

    @eagarvey-amd
    eagarvey-amd committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    e554da8 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. xfail stateless llama test

    @monorimet
    monorimet authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    cdd2f66 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Flag updates and parametrize a few more args.

    @eagarvey-amd
    eagarvey-amd committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    d23a45b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'merge_punet_sdxl' of https://github.com/nod-ai/SHARK-Tu… 

    …rbine into merge_punet_sdxl
    @eagarvey-amd
    eagarvey-amd committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    7ecfece View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Update SDXL tests, README for running on GFX942

    @eagarvey-amd
    eagarvey-amd committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    2d7a92e View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2024

  1. Fix vae script CLI and revert precision changes to sd3 text encoders … 

    …export
    @eagarvey-amd
    eagarvey-amd committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    18bffdb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'merge_punet_sdxl' of https://github.com/nod-ai/SHARK-Tu… 

    …rbine into merge_punet_sdxl
    @eagarvey-amd
    eagarvey-amd committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    df85dca View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Small fixes to compile modes and requirements

    @eagarvey-amd
    eagarvey-amd committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    674128e View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Adds explicit model arch flag, remove commented code

    @eagarvey-amd
    eagarvey-amd committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    4d6198b View commit details
    Browse the repository at this point in the history

  2. Fix formatting

    @eagarvey-amd
    eagarvey-amd committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    f3e3fe3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into merge_punet_sdxl

    @monorimet
    monorimet authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    2ed8037 View commit details
    Browse the repository at this point in the history

  4. Fix formatting

    @eagarvey-amd
    eagarvey-amd committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    7adfc7a View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Update test_models.yml

    @monorimet
    monorimet authored Sep 10, 2024
    Configuration menu
    Copy the full SHA
    ff2c3c9 View commit details
    Browse the repository at this point in the history

  2. Decompose CLIP attention

    @eagarvey-amd
    eagarvey-amd committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    afdb8d6 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. decompose implementation for clip

    @eagarvey-amd
    eagarvey-amd committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    a4e67e8 View commit details
    Browse the repository at this point in the history

  2. Add decompose clip flag to pipe e2e test

    @eagarvey-amd
    eagarvey-amd committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    35517d9 View commit details
    Browse the repository at this point in the history

  3. Add attention decomposition mechanism to sdxl clip exports.

    @eagarvey-amd
    eagarvey-amd committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    6ca109a View commit details
    Browse the repository at this point in the history

  4. Update compile options for sdxl

    @eagarvey-amd
    eagarvey-amd committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    453fb38 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Decompose VAE for cpu

    @eagarvey-amd
    eagarvey-amd committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c0be575 View commit details
    Browse the repository at this point in the history

  2. skip i8 punet test on cpu

    @eagarvey-amd
    eagarvey-amd committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    e3cd69d View commit details
    Browse the repository at this point in the history

  3. Don't use spec for clip by default

    @eagarvey-amd
    eagarvey-amd committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    e3e1dcb View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Revert change to attention spec handling in sdxl test

    @monorimet
    monorimet authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    56d6ee7 View commit details
    Browse the repository at this point in the history

  2. Don't use td spec for clip bs2 export test

    @monorimet
    monorimet authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d330564 View commit details
    Browse the repository at this point in the history

  3. disable attn spec usage for sdxl bs2 on mi250 tests

    @monorimet
    monorimet authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    ffba3ea View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. Update test_models.yml

    @monorimet
    monorimet authored Sep 14, 2024
    Configuration menu
    Copy the full SHA
    fad7e6e View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Update test_models.yml

    @monorimet
    monorimet authored Sep 16, 2024
    Configuration menu
    Copy the full SHA
    05fa32d View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Small fixes to SDXL inference pipeline/exports/compile

    @eagarvey-amd
    eagarvey-amd committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    0291d43 View commit details
    Browse the repository at this point in the history

  2. Pin torch to 2.4.1

    @eagarvey-amd
    eagarvey-amd committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    e337f2a View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Largely disables attn spec usage.

    @eagarvey-amd
    eagarvey-amd committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    0fd8ad0 View commit details
    Browse the repository at this point in the history

  2. Update canonicalization pass name, decouple model validation from pip… 

    …eline one-shot/exprt
    @eagarvey-amd
    eagarvey-amd committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    e1c4ac2 View commit details
    Browse the repository at this point in the history

  3. Don't use punet spec.

    @eagarvey-amd
    eagarvey-amd committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    61bb4ef View commit details
    Browse the repository at this point in the history

  4. Remove default/mfma/wmma specs from sd compile utils.

    @eagarvey-amd
    eagarvey-amd committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    dfb9474 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Guard path check for attn spec

    @eagarvey-amd
    eagarvey-amd committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    9fe20a6 View commit details
    Browse the repository at this point in the history

  2. Separate punet run

    @eagarvey-amd
    eagarvey-amd committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f39b2d2 View commit details
    Browse the repository at this point in the history

  3. typo fixes

    @eagarvey-amd
    eagarvey-amd committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d3c8e80 View commit details
    Browse the repository at this point in the history

  4. Filename fixes, explicit input dtypes for i8 punet

    @eagarvey-amd
    eagarvey-amd committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    40808db View commit details
    Browse the repository at this point in the history

  5. Update CPU test configuration.

    @eagarvey-amd
    eagarvey-amd committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    e630d39 View commit details
    Browse the repository at this point in the history

  6. Decompose VAE for cpu

    @eagarvey-amd
    eagarvey-amd committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    fc6d018 View commit details
    Browse the repository at this point in the history

  7. Change compile flag reporting to CLI input

    @eagarvey-amd
    eagarvey-amd committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    7d50dc8 View commit details
    Browse the repository at this point in the history

  8. formatting

    @eagarvey-amd
    eagarvey-amd committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f140926 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Rework prompt encoder export on aot.export API

    @eagarvey-amd
    eagarvey-amd committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    67e6558 View commit details
    Browse the repository at this point in the history