Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import onnx tests with new iree-import-onnx on onnx 1.16.1. #240

Merged
merged 4 commits into from
May 28, 2024

Conversation

ScottTodd
Copy link
Member

@ScottTodd ScottTodd commented May 28, 2024

This pulls in iree-org/iree#17476 which now runs shape inference: onnx.shape_inference.infer_shapes(model, data_prop=True).

Generated from an already configured venv with:

python -m pip install --upgrade --find-links https://iree.dev/pip-release-links.html iree-compiler
python -m pip install --upgrade onnx
python .\onnx\import_tests.py

@ScottTodd ScottTodd marked this pull request as ready for review May 28, 2024 18:04
@ScottTodd ScottTodd requested a review from saienduri May 28, 2024 18:04
@ScottTodd
Copy link
Member Author

Hmm still need to iterate on the CPU models xfails.

@saienduri
Copy link
Contributor

@ScottTodd
Copy link
Member Author

Thanks, that worked. When we refactor those jobs next, we could make those steps continue to show all errors instead of just the first. (I had a branch refactoring the jobs into a matrix, can pull that in...)

Copy link
Contributor

@saienduri saienduri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ScottTodd ScottTodd merged commit 06c26d7 into nod-ai:main May 28, 2024
3 checks passed
@ScottTodd ScottTodd deleted the iree-import-latest branch May 28, 2024 19:35
renxida pushed a commit that referenced this pull request Jul 18, 2024
This pulls in iree-org/iree#17476 which now runs
shape inference: `onnx.shape_inference.infer_shapes(model,
data_prop=True)`.

Generated from an already configured venv with:
```
python -m pip install --upgrade --find-links https://iree.dev/pip-release-links.html iree-compiler
python -m pip install --upgrade onnx
python .\onnx\import_tests.py
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants