Skip to content

Commit

Permalink
Removed the iree_thread_join in the cleanup of deferred_work_queue.c (i…
Browse files Browse the repository at this point in the history
…ree-org#18605)

This was cuasing ASAN errors as pthread_join was getting called twice.
We don't actually need to explicitly join these threads as
iree_thread_release will join the thread on our behalf anyway.

Fixes iree-org#18449

Signed-off-by: Andrew Woloszyn <[email protected]>
  • Loading branch information
AWoloszyn authored Sep 26, 2024
1 parent b13d38b commit 5a2dd56
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions runtime/src/iree/hal/utils/deferred_work_queue.c
Original file line number Diff line number Diff line change
Expand Up @@ -598,10 +598,7 @@ void iree_hal_deferred_work_queue_destroy(
// Request the workers to exit.
iree_hal_deferred_work_queue_request_exit(work_queue);

iree_thread_join(work_queue->worker_thread);
iree_thread_release(work_queue->worker_thread);

iree_thread_join(work_queue->completion_thread);
iree_thread_release(work_queue->completion_thread);

iree_hal_deferred_work_queue_working_area_deinitialize(
Expand Down

0 comments on commit 5a2dd56

Please sign in to comment.