Skip to content

Commit

Permalink
Address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
vinayakdsci committed Sep 20, 2024
1 parent 8c17229 commit de47766
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -228,23 +228,6 @@ Status GraphInfo::Initialize() {
}

const onnx::TypeProto *GraphInfo::FindTypeProtoForName(std::string_view name) {
// Node outputs don't typically have type information, but shape inference
// will associate them in the value_info. If not there, it may be a
// graph output, which must have type information.
#if 0
{
auto it = value_info_map_.find(name);
if (it != value_info_map_.end()) {
return &it->second.type();
}
}
{
auto it = output_map_.find(name);
if (it != output_map_.end()) {
return &it->second.type();
}
}
#endif
return graph_viewer_.GetNodeArg(std::string{name})->TypeAsProto();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#include "onnx/onnx_pb.h"

#include <optional>
#include <memory>

Check warning on line 25 in onnxruntime/core/providers/iree/compiler/torch-mlir-import-onnx/OnnxImporter.h

View workflow job for this annotation

GitHub Actions / Optional Lint C++

[cpplint] reported by reviewdog 🐶 Found C++ system header after other header. Should be: OnnxImporter.h, c system, c++ system, other. [build/include_order] [4] Raw Output: onnxruntime/core/providers/iree/compiler/torch-mlir-import-onnx/OnnxImporter.h:25: Found C++ system header after other header. Should be: OnnxImporter.h, c system, c++ system, other. [build/include_order] [4]
#include <string_view>
#include <unordered_map>

Expand Down

0 comments on commit de47766

Please sign in to comment.