Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request: Twitter-In node topics on input, refresh interval input #803

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hgill
Copy link

@hgill hgill commented May 5, 2021

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Updates on Twitter-In node:

  1. Node now takes topic string input rather than hard-coded
  2. "Sticky" followers: If new input string suggests updates in handles to follow, creates "sticky" new intervals - meaning previously followed handles are maintained, new ones added
  3. Node now takes refresh time as an input value, previously hardcoded at 60s

Other info:
4. I didn't add unit test cases, as I couldn't get the unit test lib to work as expected - can do with some guidance
5. I intended to use the latest Twitter API v2 which has breaking changes, but till v1.1 is functioning, thought it's best to let it be. When Twitter announces sunsetting of v1.1, I would like to contribute to upgrading this library to support v2.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

…er than hard-coded 2. "Sticky" followers: If new input string suggests updates in handles to follow, creates "sticky" new intervals - meaning previously followed handles are maintained, new ones added 3. Node now takes refresh time as an input value, previously hardcoded at 60s
@hgill hgill changed the title Updates on Twitter-In node: 1. Node now takes topic string input rath… Pull Request: Twitter-In node topics on input, refresh interval input May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant