Node-red-node-twitter retweet support

[baruchiro]

Fixes #834

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Proposed changes

See #834. The retweet endpoint is different from the update endpoint, and I added it to the output node.

Checklist

• I have read the contribution guidelines
• For non-bugfix PRs, I have discussed this change on the forum/slack team:
  No answers in the forum, but we discussed on Node-red-node-twitter retweet support #834.
• I have run grunt to verify the unit tests pass
• I have added suitable unit tests to cover the new/changed functionality:
  Unfortunately, there are no tests for Twitter Nodes.

[baruchiro]

For example, if you're using the Twitter Input Node with all the #some_hashtag, it will retweet the tweet with the #some_hashtag, and then, it will get it again, as a retweet.

If you will not filter it, it will try to retweet it again, and you will get an error "you already retweeted this".

[dceejay]

Can this check not be done within the node ?

[baruchiro]

How do you suggest doing that?

We can accept the whole tweet object. If we want to keep it simple with just retweet with the tweet ID, I guess we need to use the Twitter API to first check if the tweet ID has already been retweeted by us. I think it is complicated, and I wanted to start with simpler solution.

[dceejay]

If we don’t know how to do it then advising the user that they should is just passing the buck isn't it ?

[knolleary]

I would suggest changing the wording from:

Before retweeting, make sure the tweet is not a retweet itself.

to

You cannot retweet a retweet. You can check if it is a retweet using the `msg.tweet.XYZ` property.

(assuming these is a property under msg.tweet that does the job)

[baruchiro]

I will continue to work on it next week

[baruchiro]

If we don’t know how to do it then advising the user that they should is just passing the buck isn't it ?

Originally posted by @dceejay in #835 (comment)

Not exactly. I don't know and I didn't research exactly what is the right way to validate we are not retweeting the same tweet twice, so I leave it to the user to implement a custom workaround, based on its use case.

For example, in my use-case, I'm retweeting tweets by hashtag, and I filtering all the tweets from me, so that it will never try to retweet twice, since the second tweet will be always by me.

[baruchiro]

I would suggest changing the wording from:

Before retweeting, make sure the tweet is not a retweet itself.

to

You cannot retweet a retweet. You can check if it is a retweet using the `msg.tweet.XYZ` property.

(assuming these is a property under msg.tweet that does the job)

Originally posted by @knolleary in #835 (comment)

I'm very welcome to documentation improvements, my English is not so good. But about this specific suggestion, please see the previous comment. You can retweet a retweet, AFAIK, but you can't retweet tweet you already retweeted yourself. And I'm not sure how to check this (possibly by checking if one of the retweets of a tweets made by me...)

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Baruch Odem (Rothkoff) (21f31cf)