Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few improvements to calendar node #265

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

A few improvements to calendar node #265

wants to merge 3 commits into from

Conversation

dsl400
Copy link

@dsl400 dsl400 commented Oct 3, 2020

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

node settings now allows selection of calendar by name instead of pasting in the id or name of the calendar
added ability to get complete list of calendars and filter it

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

node settings now allows selection of calendar by name instead of pasting in the id or name of the calendar
added ability to get complete list of calendars and filter it
node settings now allows selection of calendar by name instead of pasting in the id or name of the calendar
added ability to get complete list of calendars and filter it
@dceejay
Copy link
Member

dceejay commented Oct 25, 2020

Hi @dsl400,
apologies for not getting to this. Due to another previous PR this now has conflicts... any chance you can resolve them for us and check your PR still works as intended ? And please run grunt to check tests pass... Many thanks

@dceejay
Copy link
Member

dceejay commented Nov 23, 2020

Very close - sadly we still like { } :-)

and we now seem to have nextStartingEvent defined twice...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants