import executables also work on Node.js v20.10.0

nodejs · Nov 30, 2023 · e4257ba · e4257ba
1 parent f935c89
commit e4257ba
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -10,7 +10,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [12.x, 14.x, 16.10.0, 16.16.0, 16.17.0, 16.x, 17.x, 18.5.0, 18.x, 20.x, 21.x]
+        node-version: [12.x, 14.x, 16.10.0, 16.16.0, 16.17.0, 16.x, 17.x, 18.5.0, 18.x, 20.9.0, 20.x, 21.x]
         os: [ubuntu-latest, macos-latest, windows-latest]
 
     steps:

diff --git a/test/other/import-executable.mjs b/test/other/import-executable.mjs
@@ -4,9 +4,11 @@
 
 import { rejects } from 'assert'
 (async () => {
-  const [processMajor] = process.versions.node.split('.').map(Number)
-  if (processMajor >= 21) {
-    // Files without extension are supported in Node.js 21+
+  const [processMajor, processMinor] = process.versions.node.split('.').map(Number)
+  const extensionlessSupported = processMajor >= 21 ||
+    (processMajor === 20 && processMinor >= 10)
+  if (extensionlessSupported) {
+    // Files without extension are supported in Node.js >= 20.10.0
     return
   }
   await rejects(() => import('./executable'), {