-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): temporarily disable OS X #368
Conversation
cc @nodejs/llnode |
It seems that |
Co-authored-by: Joyee Cheung <[email protected]>
Ah yes, that might cause v14 tests to fail, although I'm pretty sure llnode is broken on v14 since we bumped V8 recently (as in, after the last time we updated things on llnode). |
Codecov Report
@@ Coverage Diff @@
## master #368 +/- ##
==========================================
+ Coverage 78.93% 78.98% +0.05%
==========================================
Files 33 33
Lines 4262 4744 +482
==========================================
+ Hits 3364 3747 +383
- Misses 898 997 +99
Continue to review full report at Codecov.
|
From nodejs/node#32981 it seems the bug was introduced from v12.11.0. Is there any progress in the V8 upstream? |
I don't think I opened an upstream bug 🤔 I'll check tomorrow and will open one if I haven't yet. |
Although tests are passing on v12, so that issue should be unrelated (hopefully) |
Refs: #362