src: lock the thread properly in snapshot builder

Otherwise it can crash DCHECK when V8 expects that at least someone is locking the current thread. PR-URL: #56327 Fixes: nodejs/node-v8#294 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
nodejs · Jan 7, 2025 · 7c3aa9f · 7c3aa9f
1 parent 75b9c1c
commit 7c3aa9f
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/node_snapshotable.cc b/src/node_snapshotable.cc
@@ -962,6 +962,8 @@ ExitCode BuildSnapshotWithoutCodeCache(
   }
 
   Isolate* isolate = setup->isolate();
+  v8::Locker locker(isolate);
+
   {
     HandleScope scope(isolate);
     TryCatch bootstrapCatch(isolate);