fixup! src: drain platform tasks before creating startup snapshot

nodejs · Jan 6, 2025 · c1a5d20 · c1a5d20
1 parent 4642ec5
commit c1a5d20
Showing 1 changed file with 0 additions and 4 deletions.
diff --git a/src/node_snapshotable.cc b/src/node_snapshotable.cc
@@ -992,10 +992,6 @@ ExitCode BuildSnapshotWithoutCodeCache(
     // example, a WeakRef may schedule an per-isolate platform task as a GC
     // root, and referencing an object in a context, causing an assertion in
     // the snapshot creator.
-
-    // FIXME(joyeecheung): right now running the loop in the snapshot
-    // builder might introduce inconsistencies in JS land that need to
-    // be synchronized again after snapshot restoration.
     ExitCode exit_code =
         SpinEventLoopInternal(env).FromMaybe(ExitCode::kGenericUserError);
     if (exit_code != ExitCode::kNoFailure) {