src: move more crypto impl detail to ncrypto dep #56421
Open
+1,049
−597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
lib / src
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
reviewed
Jan 1, 2025
jasnell
force-pushed
the
jasnell/even-moar-ncrypto
branch
from
a31e0e1 to
9f20d9e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/even-moar-ncrypto
branch
from
9f20d9e to
69e42d9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Jan 1, 2025
jasnell
added
the
author ready
Nothing was using it.
Only used one place so move it out of crypto-common
jasnell
force-pushed
the
jasnell/even-moar-ncrypto
branch
from
69e42d9 to
1093eec
Compare
jasnell
force-pushed
the
jasnell/even-moar-ncrypto
branch
from
2466074 to
4f43fd0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
@anonrig... Added a bit more here |
|
anonrig
reviewed
Jan 2, 2025
jasnell
force-pushed
the
jasnell/even-moar-ncrypto
branch
from
4f43fd0 to
a332b90
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Jan 3, 2025
jasnell
added
crypto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.