src: fixup more ToLocalChecked uses in node_file #56484
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
This comment was marked as outdated.
This comment was marked as outdated.
daeyeon
reviewed
Jan 6, 2025
|
It seems like there are a few mistakes. |
|
@daeyeon ... good catch lol |
jasnell
force-pushed
the
jasnell/moar-tolocalchecked-fixes
branch
from
37b4131 to
84d5097
Compare
This comment was marked as outdated.
This comment was marked as outdated.
daeyeon
approved these changes
Jan 7, 2025
daeyeon
added
the
author ready
addaleax
approved these changes
Jan 7, 2025
anonrig
approved these changes
Jan 7, 2025
jasnell
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/56484 ✔ Done loading data for nodejs/node/pull/56484 ----------------------------------- PR info ------------------------------------ Title src: fixup more ToLocalChecked uses in node_file (#56484) Author James M Snell <[email protected]> (@jasnell) Branch jasnell:jasnell/moar-tolocalchecked-fixes -> nodejs:main Labels c++, fs, author ready Commits 1 - src: fixup more ToLocalChecked uses in node_file Committers 1 - James M Snell <[email protected]> PR-URL: https://github.com/nodejs/node/pull/56484 Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56484 Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 05 Jan 2025 21:50:21 GMT ✔ Approvals: 3 ✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/56484#pullrequestreview-2533213818 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/56484#pullrequestreview-2534994017 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/56484#pullrequestreview-2535092610 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2025-01-07T01:08:47Z: https://ci.nodejs.org/job/node-test-pull-request/64379/ - Querying data for job/node-test-pull-request/64379/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/12659954275 |
jasnell
added a commit
that referenced
this pull request
Jan 7, 2025
PR-URL: #56484 Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
|
Landed in 8d9dac4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.