Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use spawnSyncAndExit{,WithoutError}() #56529

Closed
wants to merge 1 commit into from
Closed

test: use spawnSyncAndExit{,WithoutError}() #56529

wants to merge 1 commit into from
+23 −22

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Jan 9, 2025 •
edited
Loading

Use spawnSyncAndExit() and spawnSyncAndExitWithoutError() in
test/parallel/test-macos-app-sandbox.js.

Refs: #54802 (comment)

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 9, 2025
@lpinca lpinca force-pushed the improve/test-macos-app-sandbox branch from 3871b83 to 01e4d77 Compare January 9, 2025 09:00
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.16%. Comparing base (dc5d0f9) to head (b6a59dd).
Report is 11 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56529      +/-   ##
==========================================
- Coverage   89.16%   89.16%   -0.01%     
==========================================
  Files         662      662              
  Lines      191668   191672       +4     
  Branches    36884    36883       -1     
==========================================
- Hits       170908   170905       -3     
- Misses      13621    13627       +6     
- Partials     7139     7140       +1

see 42 files with indirect coverage changes

@lpinca lpinca force-pushed the improve/test-macos-app-sandbox branch 3 times, most recently from 396e17c to c57b24a Compare January 9, 2025 13:06
@lpinca
test: use spawnSyncAndExit{,WithoutError}()
b6a59dd 
Use `spawnSyncAndExit()` and `spawnSyncAndExitWithoutError()` in
`test/parallel/test-macos-app-sandbox.js`.

Refs: nodejs#54802 (comment)
@lpinca lpinca force-pushed the improve/test-macos-app-sandbox branch from c57b24a to b6a59dd Compare January 9, 2025 13:11
@lpinca lpinca changed the title test: use spawnSyncAndExitWithoutError() test: use spawnSyncAndExit{,WithoutError}() Jan 9, 2025
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64423/

@lpinca
Copy link
Member Author

lpinca commented Jan 10, 2025

spawnSyncAndExit() is not very useful here as the process is terminated with SIGTRAP or SIGKILL in CI. It's not worth the effort. I'm closing this.

@lpinca lpinca closed this Jan 10, 2025
@lpinca lpinca deleted the improve/test-macos-app-sandbox branch January 10, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lpinca @nodejs-github-bot