util: inspect: do not crash on an Error stack that contains a Symbol

[ljharb]

See #56570 - this avoids a crash when an Error's stack property contains a Symbol inside an array

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/64461/ 💛

[codecov]

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.14%. Comparing base (bf59539) to head (3523bf2).

Files with missing lines	Patch %	Lines
lib/internal/util/inspect.js	81.81%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #56573      +/-   ##
==========================================
- Coverage   89.21%   89.14%   -0.07%     
==========================================
  Files         662      662              
  Lines      191934   191940       +6     
  Branches    36945    36889      -56     
==========================================
- Hits       171227   171114     -113     
- Misses      13543    13672     +129     
+ Partials     7164     7154      -10     

Files with missing lines	Coverage Δ
lib/internal/util/inspect.js	95.21% <81.81%> (-4.71%)	⬇️

... and 41 files with indirect coverage changes

[BridgeAR]

We could try to still log something more helpful than just the array with the symbol in it. Something like:

Error
    [Symbol(foo)]

We just have to detect it's deviating from regular errors.

[BridgeAR]

Landing this as is is an improvement over the current situation (since it does not error anymore), while I believe we should push for a tad more and show the error name and message as well.

[BridgeAR]

Could we change the improveStack() method to result in:

Error: message
[\n
  Symbol(foo)\n
]

I think that would be beneficial. Otherwise it's going to be very tricky to understand what the output is about.

[ljharb]

Unfortunately, it seems like assigning .name stringifies it immediately, so we can't alter rendering behavior based on that later. Thoughts?

[BridgeAR]

After giving it another thought, I think it is best to land this as is and improve the error output later.
Error output for these cases is broken one way or the other and this is an improvement, even without the other part (which is tricky, since stack traces can have an arbitrary shape).

[BridgeAR]

Suggested change

	if (error.stack) {
	if (typeof error.stack === 'string') {
	return error.stack;
	}
	return formatValue(ctx, error.stack);
	}
	if (typeof error.stack === 'string') {
	return error.stack;
	}
	if (error.stack != null) {
	return formatValue(ctx, error.stack);
	}

[ljharb]

Per discussion, this change breaks some output. is it ok to land this as-is?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/64630/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/64652/