Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix inconsistencies in WeakSet and WeakMap comparison details #56683

Merged
merged 1 commit into from
Jan 23, 2025
Merged

doc: fix inconsistencies in WeakSet and WeakMap comparison details #56683

merged 1 commit into from
Jan 23, 2025
+8 −6

Conversation

ishon19
Copy link
Contributor

@ishon19 ishon19 commented Jan 21, 2025

This PR fixes the inconsistencies in the comparison example added in #56648.

Part of #56640

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Jan 21, 2025
@ishon19
Copy link
Contributor Author

ishon19 commented Jan 21, 2025

@BridgeAR I created this PR to fix the issues in the main one, please let me know if it looks good :)

@lpinca
Copy link
Member

lpinca commented Jan 23, 2025

@ishon19 can you please rebase and force push?

@ishon19 ishon19 force-pushed the 56640-fix-missing-doc-changes branch from 9bdeabc to 52dd838 Compare January 23, 2025 16:11
@ishon19
Copy link
Contributor Author

ishon19 commented Jan 23, 2025

@ishon19 can you please rebase and force push?

Absolutely, just did!

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 23, 2025
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 23, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 23, 2025
@nodejs-github-bot nodejs-github-bot merged commit 3d861c4 into nodejs:main Jan 23, 2025
21 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 3d861c4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jazelly jazelly jazelly approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ishon19 @lpinca @nodejs-github-bot @UlisesGascon @BridgeAR @jazelly