test: use --permission instead of --experimental-permission #56685
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafaelGSS
added
the
fast-track
|
Review requested:
|
nodejs-github-bot
added
needs-ci
|
Fast-track has been requested by @RafaelGSS. Please 👍 to approve. |
marco-ippolito
approved these changes
Jan 21, 2025
github-actions
bot
removed
the
request-ci
cjihrig
approved these changes
Jan 21, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56685 +/- ##
=======================================
Coverage 89.21% 89.21%
=======================================
Files 662 662
Lines 191934 191934
Branches 36945 36945
=======================================
+ Hits 171227 171240 +13
+ Misses 13543 13535 -8
+ Partials 7164 7159 -5 |
pmarchini
approved these changes
Jan 21, 2025
|
Both Windows JS suite and RHEL8 seem to be broken on |
LiviaMedeiros
approved these changes
Jan 22, 2025
|
I opened nodejs/build#4005 for the Windows issue. |
lpinca
approved these changes
Jan 22, 2025
BridgeAR
approved these changes
Jan 22, 2025
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 01dd7c4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes main. I've cherry-picked the v23.x security release commits into main and I forgot we've removed
--experimental-permissionin main.