doc: add note for features using InternalWorker with permission model
#56706
+27
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
aduh95
added
backport-requested-v20.x
jasnell
approved these changes
Jan 22, 2025
|
@nodejs/lts are we OK landing this in the 20.18.3 proposal? I feel that fixing the documentation earlier rather than later, since the incomplete documentation just got out in the security release and we don't know when will be the next 20.x release. |
I'm okay with landing it as a correction to the security release. |
richardlau
approved these changes
Jan 22, 2025
aduh95
added
fast-track
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
jasnell
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/56706 ✔ Done loading data for nodejs/node/pull/56706 ----------------------------------- PR info ------------------------------------ Title doc: add note for features using `InternalWorker` with permission model (#56706) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:internal-worker--permission -> nodejs:main Labels doc, fast-track, author ready, backport-requested-v20.x, backport-requested-v22.x, backport-requested-v23.x Commits 1 - doc: add note for features using `InternalWorker` with permission model Committers 1 - Antoine du Hamel <[email protected]> PR-URL: https://github.com/nodejs/node/pull/56706 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56706 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 22 Jan 2025 15:38:16 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/56706#pullrequestreview-2567620269 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/56706#pullrequestreview-2567850495 ℹ This PR is being fast-tracked ✘ This PR needs to wait 45 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/12914652510 |
jasnell
removed
the
commit-queue-failed
lpinca
approved these changes
Jan 23, 2025
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a4895e2 |
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Jan 23, 2025
PR-URL: nodejs#56706 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
added a commit
that referenced
this pull request
Jan 23, 2025
PR-URL: #56706 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
removed
backport-requested-v20.x
aduh95
added
backport-open-v20.x
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Jan 23, 2025
PR-URL: nodejs#56706 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jan 23, 2025
PR-URL: #56706 Backport-PR-URL: #56721 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jan 23, 2025
PR-URL: #56706 Backport-PR-URL: #56721 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bf59539 did not include documentation for all features depending on
InternalWorker.