Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: enforce shouldColorize in styleText array arg #56722

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marco-ippolito
Copy link
Member

Fixes: #56717

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.22%. Comparing base (d978610) to head (74f3eb3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #56722   +/-   ##
=======================================
  Coverage   89.21%   89.22%           
=======================================
  Files         662      662           
  Lines      191945   191950    +5     
  Branches    36948    36943    -5     
=======================================
+ Hits       171238   171259   +21     
+ Misses      13549    13543    -6     
+ Partials     7158     7148   -10     
Files with missing lines Coverage Δ
lib/util.js 97.78% <100.00%> (+0.02%) ⬆️

... and 22 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

util.styleText is not respecting NO_COLOR when first argument is an array.
3 participants