Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use node test runner #90

Merged
merged 5 commits into from
Jun 23, 2024
Merged

Conversation

AugustinMauroy
Copy link
Member

@AugustinMauroy AugustinMauroy commented Jun 21, 2024

Just remove jest form devdep and use node 😄

@AugustinMauroy
Copy link
Member Author

AugustinMauroy commented Jun 21, 2024

it's work on local, I thinks it's because GitHub use main workflow file ?

Capture d’écran 2024-06-21 à 11 47 04

@UlisesGascon
Copy link
Member

Thanks for doing this, @AugustinMauroy!

I think there might be a typo in the pipeline. Could you create a separate PR just for this commit? It seems the CI might not be passing with Jest due to this issue. 🤔

package.json Outdated Show resolved Hide resolved
@UlisesGascon
Copy link
Member

mmm... I was checking the errors in the pipeline. Maybe the issue is related to the timezone and we can solve it by adding an specific timezone with the TZ environmental variable https://stackoverflow.com/a/9849524 in the npm script 🤔

Screenshot from 2024-06-22 13-40-41

Feel free to include 006496a as anyway the tests with Jest seems to be failing in the CI based on #92

@UlisesGascon UlisesGascon mentioned this pull request Jun 22, 2024
@UlisesGascon
Copy link
Member

Seems like #92 also solved the issue with the tests in this case, so I merged the changes in this branch.

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready now! Great work @AugustinMauroy! 🥳

@UlisesGascon UlisesGascon merged commit 5636717 into nodejs:main Jun 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants