Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace commander with parseArgs #67

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

debadree25
Copy link
Member

Have attempted to replace commander to parseArgs as per #56

@debadree25 debadree25 changed the title Ft/replace comander parse args src: replace commander with parseArgs Dec 18, 2022
@debadree25
Copy link
Member Author

debadree25 commented Dec 18, 2022

I have tried running tests locally but the build seem to be failing with this error

/Users/debadreechatterjee/Documents/Personal/postject/test/../dist/postject-api.h:68:11: error: 'getsectdatafromFramework' is deprecated: first deprecated in macOS 13.0 - No longer supported [-Werror,-Wdeprecated-declarations]```

@RaisinTen
Copy link
Contributor

Thanks a lot for sending the PR! 🙏 CI is blocked on #62, so I'll take a look after that gets resolved.

Could you also open an issue for the compilation failure? Seems like Apple deprecated getsectdatafromFramework() and getsectdata() in macOS Ventura.

@RaisinTen RaisinTen linked an issue Dec 19, 2022 that may be closed by this pull request
@debadree25
Copy link
Member Author

Thanks a lot for sending the PR! 🙏 CI is blocked on #62, so I'll take a look after that gets resolved.

Could you also open an issue for the compilation failure? Seems like Apple deprecated getsectdatafromFramework() and getsectdata() in macOS Ventura.

Yes creating an issue for that!

@debadree25 debadree25 changed the title src: replace commander with parseArgs refactor: replace commander with parseArgs Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace commander with parseArgs
2 participants