fix: Check for kUnknown ExecutableFormat #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfellis
requested review from
RaisinTen,
dsanders11,
jviotti and
robertgzr
as code owners
dfellis
changed the title
RaisinTen
reviewed
Apr 29, 2023
There was a problem hiding this comment.
Nice catch, thanks!
(Posting the link to where you found this - #12 (comment) for context for others)
if any, testing is wanted
Yea, would be nice if we could add a test to test/cli.mjs that tries to create a temporary file with an invalid format (I guess it could even be an empty file) and checks that postject throws the right exception
Co-authored-by: Darshan Sen <[email protected]>
RaisinTen
reviewed
May 1, 2023
There was a problem hiding this comment.
I ran CI on my fork - https://app.circleci.com/pipelines/github/RaisinTen/postject/3/workflows/a0657615-c702-4934-88b5-2b3bb41706ac and there are some relevant errors. We can fix the linting errors by running npm run format. This test also seems to be running out of time on CI, so we could add a timeout to fix that.
Co-authored-by: Darshan Sen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure what, if any, testing is wanted for PRs. Let me know. :)