set ws readyState if closed before connection could be established

nodejs · Oct 8, 2024 · 2d9cda4 · 2d9cda4
1 parent 40fb24d
commit 2d9cda4
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/lib/web/websocket/websocket.js b/lib/web/websocket/websocket.js
@@ -471,6 +471,8 @@ class WebSocket extends EventTarget {
     }
 
     if (!this.#handler.wasEverConnected) {
+      this.#handler.readyState = states.CLOSED
+
       // If the WebSocket connection could not be established, it is also said
       // that _The WebSocket Connection is Closed_, but not _cleanly_.
       fireEvent('close', this, (type, init) => new CloseEvent(type, init), {

diff --git a/test/websocket/issue-3697-2399493917.js b/test/websocket/issue-3697-2399493917.js
@@ -0,0 +1,15 @@
+'use strict'
+
+const { test } = require('node:test')
+const { WebSocket } = require('../..')
+const { tspl } = require('@matteo.collina/tspl')
+
+// https://github.com/nodejs/undici/issues/3697#issuecomment-2399493917
+test('closing before a connection is established changes readyState', async (t) => {
+  const { completed, strictEqual } = tspl(t, { plan: 1 })
+
+  const ws = new WebSocket('wss://example.com/non-existing-url')
+  ws.onclose = () => strictEqual(ws.readyState, WebSocket.CLOSED)
+
+  await completed
+})