fix(3951): typo on errorede dns lookup (#3956)

* fix(3951): typo on errorede dns lookup * test: add testing
nodejs · Dec 18, 2024 · 3eeeeb7 · 3eeeeb7
1 parent 29760e7
commit 3eeeeb7
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/lib/interceptor/dns.js b/lib/interceptor/dns.js
@@ -353,7 +353,7 @@ module.exports = interceptorOpts => {
 
       instance.runLookup(origin, origDispatchOpts, (err, newOrigin) => {
         if (err) {
-          return handler.onError(err)
+          return handler.onResponseError(null, err)
         }
 
         let dispatchOpts = null

diff --git a/test/interceptors/dns.js b/test/interceptors/dns.js
@@ -1865,3 +1865,28 @@ test('#3937 - Handle host correctly', async t => {
   t.equal(response2.statusCode, 200)
   t.equal(await response2.body.text(), 'hello world!')
 })
+
+test('#3951 - Should handle lookup errors correctly', async t => {
+  const suite = tspl(t, { plan: 1 })
+
+  const requestOptions = {
+    method: 'GET',
+    path: '/',
+    headers: {
+      'content-type': 'application/json'
+    }
+  }
+
+  const client = new Agent().compose([
+    dns({
+      lookup: (_origin, _opts, cb) => {
+        cb(new Error('lookup error'))
+      }
+    })
+  ])
+
+  suite.rejects(client.request({
+    ...requestOptions,
+    origin: 'http://localhost'
+  }), new Error('lookup error'))
+})