code review

Signed-off-by: flakey5 <[email protected]>
nodejs · Oct 18, 2024 · 5ceba5e · 5ceba5e
1 parent ab2d8dd
commit 5ceba5e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/lib/interceptor/cache.js b/lib/interceptor/cache.js
@@ -30,9 +30,11 @@ module.exports = (opts = {}) => {
     methods
   }
 
+  const safeMethodsToNotCache = util.safeHTTPMethods.filter(method => methods.includes(method) === false)
+
   return dispatch => {
     return (opts, handler) => {
-      if (!opts.origin || (util.safeHTTPMethods.includes(opts.method) && !methods.includes(opts.method))) {
+      if (!opts.origin || safeMethodsToNotCache.includes(opts.method)) {
         // Not a method we want to cache or we don't have the origin, skip
         return dispatch(opts, handler)
       }

diff --git a/test/interceptors/cache.js b/test/interceptors/cache.js
@@ -292,13 +292,17 @@ describe('Cache Interceptor', () => {
 
     strictEqual(deleteByOriginCalled, false)
 
-    // Make sure unsafe methods cause a cache purge
-    await client.request({
-      origin: 'localhost',
-      method: 'DELETE',
-      path: '/'
-    })
+    // Make sure the common unsafe methods cause cache purges
+    for (const method of ['POST', 'PUT', 'PATCH', 'DELETE']) {
+      deleteByOriginCalled = false
+
+      await client.request({
+        origin: 'localhost',
+        method,
+        path: '/'
+      })
 
-    equal(deleteByOriginCalled, true)
+      equal(deleteByOriginCalled, true, method)
+    }
   })
 })