Apply suggestions from code review

Co-authored-by: Robert Nagy <[email protected]>

lib/core/util.js

@@ -486,14 +486,7 @@ function encodeRawHeaders (headers) {
   if (!Array.isArray(headers)) {
     throw new TypeError('expected headers to be an array')
   }
-
-  const rawHeaders = new Array(headers.length)
-
-  for (let i = 0; i < headers.length; i++) {
-    rawHeaders[i] = Buffer.from(headers[i])
-  }
-
-  return rawHeaders
+  return headers.map(x => Buffer.from(x))
 }
 
 /**

lib/interceptor/cache.js

@@ -89,9 +89,7 @@ module.exports = (opts = {}) => {
 
           if (typeof handler.onConnect === 'function') {
             handler.onConnect((err) => {
-              if (stream) {
-                stream.destroy(err)
-              }
+              stream?.destroy(err)
             })
 
             if (stream?.destroyed) {
@@ -182,7 +180,7 @@ module.exports = (opts = {}) => {
           }
 
           handleStream(result)
-        }).catch(handler.onError)
+        }).catch(err => handler.onError(err))
       } else {
         handleStream(result)
       }

lib/util/cache.js

@@ -19,11 +19,8 @@ function makeCacheKey (opts) {
   const cacheKey = {
     origin: opts.origin.toString(),
     method: opts.method,
-    path: opts.path
-  }
-
-  if (opts.headers) {
-    cacheKey.headers = opts.headers
+    path: opts.path,
+    headers: opts.headers
   }
 
   return cacheKey