Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetch: optimize .bytes() mixin #3608

Closed
wants to merge 1 commit into from
Closed

fetch: optimize .bytes() mixin #3608

wants to merge 1 commit into from

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Sep 14, 2024 •
edited
Loading

looks faster... :-P

Needs a Benchmark like the one for arraybuffers made by @tsctx

@mcollina mcollina requested a review from KhafraDev September 14, 2024 09:03
@tsctx
Copy link
Member

tsctx commented Sep 14, 2024

I think it will be slower.
Uint8Array.from -> To create a new buffer, loop through %Symbol.iterator%, set it in the buffer. spec
new Uint8Array -> Using an internal slot. spec

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Sep 14, 2024

no perf differnce

@Uzlopak Uzlopak closed this Sep 14, 2024
@Uzlopak Uzlopak deleted the fetch-body-bytes branch September 14, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KhafraDev KhafraDev Awaiting requested review from KhafraDev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uzlopak @tsctx