Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch: refactor referrer policy util functions #3706

Merged
merged 14 commits into from
Oct 10, 2024
Merged

fetch: refactor referrer policy util functions #3706

merged 14 commits into from
Oct 10, 2024

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Oct 8, 2024

The helper function for the referrer policy are not that strict. This PR improves the spec conformance.

lib/web/fetch/util.js Outdated Show resolved Hide resolved
lib/web/fetch/util.js Outdated Show resolved Hide resolved
@Uzlopak Uzlopak requested a review from KhafraDev October 8, 2024 22:19
lib/web/fetch/util.js Outdated Show resolved Hide resolved
lib/web/fetch/util.js Show resolved Hide resolved
lib/web/fetch/util.js Outdated Show resolved Hide resolved
lib/web/fetch/util.js Show resolved Hide resolved
lib/web/fetch/util.js Show resolved Hide resolved
lib/web/fetch/util.js Outdated Show resolved Hide resolved
lib/web/fetch/util.js Outdated Show resolved Hide resolved
lib/web/fetch/util.js Show resolved Hide resolved
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Oct 9, 2024

@KhafraDev PTAL

lib/web/fetch/util.js Outdated Show resolved Hide resolved
lib/web/fetch/util.js Outdated Show resolved Hide resolved
test/fetch/util.js Outdated Show resolved Hide resolved
test/fetch/util.js Outdated Show resolved Hide resolved
test/fetch/util.js Show resolved Hide resolved
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Oct 9, 2024

@KhafraDev
PTAL

test/fetch/util.js Outdated Show resolved Hide resolved
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Oct 9, 2024

@KhafraDev PTAL

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Oct 10, 2024

@KhafraDev

Time to approve :D

@Uzlopak Uzlopak merged commit 9c3ed66 into main Oct 10, 2024
38 checks passed
@Uzlopak Uzlopak deleted the referrer-policy branch October 10, 2024 00:29
Copy link
Contributor

The backport to v6.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v6.x v6.x
# Navigate to the new working tree
cd .worktrees/backport-v6.x
# Create a new branch
git switch --create backport-3706-to-v6.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9c3ed661e77e21eab407771058b0601fa85bb697
# Push it to GitHub
git push --set-upstream origin backport-3706-to-v6.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v6.x

Then, create a pull request where the base branch is v6.x and the compare/head branch is backport-3706-to-v6.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants