-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetch: refactor referrer policy util functions #3706
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uzlopak
commented
Oct 8, 2024
Uzlopak
commented
Oct 8, 2024
Uzlopak
commented
Oct 8, 2024
Uzlopak
commented
Oct 8, 2024
KhafraDev
requested changes
Oct 8, 2024
Co-authored-by: Khafra <[email protected]>
@KhafraDev PTAL |
KhafraDev
requested changes
Oct 9, 2024
@KhafraDev |
KhafraDev
requested changes
Oct 9, 2024
@KhafraDev PTAL |
Uzlopak
force-pushed
the
referrer-policy
branch
from
October 9, 2024 22:38
d5a8cd3
to
46c6eea
Compare
Time to approve :D |
KhafraDev
approved these changes
Oct 10, 2024
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v6.x v6.x
# Navigate to the new working tree
cd .worktrees/backport-v6.x
# Create a new branch
git switch --create backport-3706-to-v6.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9c3ed661e77e21eab407771058b0601fa85bb697
# Push it to GitHub
git push --set-upstream origin backport-3706-to-v6.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v6.x Then, create a pull request where the |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helper function for the referrer policy are not that strict. This PR improves the spec conformance.