Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translations for Guides #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chikathreesix
Copy link

I found missing translations for Guides part so translated via GitLocalize.
Please review this and give me feedbacks.

@watilde
Copy link
Member

watilde commented Apr 15, 2017

Good catch! Can you possibly make a pull request to nodejs/nodejs.org directly? This repository is not an up-to-date already.

One minor point, we have a commit message rule. In this case, we need to put nodejs-ja: as a prefix in the commit message. Thanks.

@chikathreesix
Copy link
Author

Thanks for your quick comment! OK, will do it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants