Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove function which was ignoring compiler warning to not do that #21

Merged
merged 5 commits into from
Sep 18, 2024

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

Also fixes a bunch of visibility issues and stuff.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench merged commit bb348ac into main Sep 18, 2024
3 checks passed
@iAmMichaelConnor
Copy link
Collaborator

Removing __batch_invert_slice broke the bigcurve lib (when updating that lib to the latest version of noir) in such a way that I'm not even sure how to fix it, since slices are so pervasive in bigcurve.

@TomAFrench TomAFrench deleted the fix-bad-stuff branch September 24, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants