fix: fixed reduction parameter error #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redc_param previously was only large enough to cover barrett reductions whose input was < 2^{modulus_bits * 2 + 2}
this was insufficient for elliptic curve arithmetic in bignum
redc_param is now large enough to cover barrett reduction inputs of at least 16 * modulus^2
additonally, library upgraded to not trigger compiler warnings for nargo 0.35.0
zac-williamson
changed the title
TomAFrench
reviewed
Oct 9, 2024
vezenovm
approved these changes
Oct 9, 2024
| let Y1: BigNum<$N, $typ> = unsafe{ bn.__derive_from_seed([i as u8,i as u8,6,7]) }; | ||
| let Z1: BigNum<$N, $typ> = BigNum::one(); | ||
|
|
||
| let (_, YY_mul_2): (BigNum<$N, $typ>, BigNum<$N, $typ> ) = unsafe{BigNum::__compute_quadratic_expression([[Y1]], [[false]], [[Y1, Y1]], [[false, false]], [], [])}; |
There was a problem hiding this comment.
file could use a nargo fmt. Although, I know the formatter struggles with macros.
| }; | ||
| let result = unsafe { | ||
| bn.__mul(u, v) | ||
| }; | ||
| let expected: BigNum<N, Params> = BigNum::one(); | ||
| assert(result.limbs == expected.limbs); | ||
| } | ||
| } | ||
|
|
||
| fn assert_is_not_equal<let N: u32, Params>(bn: BigNumInstance<N, Params>) where Params: BigNumParamsTrait<N> { |
There was a problem hiding this comment.
Is this func used anywhere now that we have assert_is_not_equal in the macro test with
#[make_test(quote{3},quote{BNParams})]
pub struct BNTests{}
Seems we can delete some of these functions that take in a BigNumInstance as inputs.
Co-authored-by: Maxim Vezenov <[email protected]>
Co-authored-by: Maxim Vezenov <[email protected]>
Co-authored-by: Maxim Vezenov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redc_param previously was only large enough to cover barrett reductions whose input was < 2^{modulus_bits * 2 + 2}
this was insufficient for elliptic curve arithmetic in bignum
redc_param is now large enough to cover barrett reduction inputs of at least 16 * modulus^2
additonally, library upgraded to not trigger compiler warnings for nargo 0.35.0
Description
Problem*
Resolves
Summary*
Additional Context
PR Checklist*
cargo fmton default settings.