Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement From<Field> on BigNum #87

Merged
merged 16 commits into from
Jan 16, 2025
Merged

feat: implement From<Field> on BigNum #87

merged 16 commits into from
Jan 16, 2025
+181 −16

Conversation

kashbrti
Copy link
Contributor

Description

added a method to create bignums from field elements

Problem*

Resolves

Summary*

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

kashbrti
kashbrti commented Dec 24, 2024
View reviewed changes
src/bignum.nr Outdated Show resolved Hide resolved
kashbrti
kashbrti commented Dec 24, 2024
View reviewed changes
src/fns/constrained_ops.nr Outdated Show resolved Hide resolved
@kashbrti kashbrti requested a review from TomAFrench December 24, 2024 15:21
@kashbrti kashbrti mentioned this pull request Dec 24, 2024
Open
@kashbrti kashbrti marked this pull request as ready for review January 6, 2025 15:45
@olehmisar
Copy link
Contributor

@kashbrti is this PR ready?

TomAFrench
TomAFrench reviewed Jan 15, 2025
View reviewed changes
src/utils/split_bits.nr Outdated Show resolved Hide resolved
TomAFrench
TomAFrench requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this conversion is currently entirely unconstrained.

src/utils/u60_representation.nr Outdated Show resolved Hide resolved
src/utils/u60_representation.nr Show resolved Hide resolved
src/fns/constrained_ops.nr Outdated Show resolved Hide resolved
src/fns/constrained_ops.nr Show resolved Hide resolved
src/fns/unconstrained_helpers.nr Show resolved Hide resolved
@TomAFrench TomAFrench changed the title feat: add from field method feat: implement From<Field> on BigNum Jan 16, 2025
@TomAFrench TomAFrench merged commit 35bf983 into main Jan 16, 2025
8 checks passed
@github-actions github-actions bot mentioned this pull request Jan 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olehmisar olehmisar olehmisar left review comments

@TomAFrench TomAFrench TomAFrench approved these changes

Assignees

@kashbrti kashbrti

Labels
None yet
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kashbrti @olehmisar @TomAFrench