feat!: disallow calling unconstrained functions outside of unsafe blocks and passing unconstrained functions in place of constrained functions
#6938
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocks and passing unconstrained functions in place of constrained function
TomAFrench
changed the title
unsafe bl…unsafe blocks and passing unconstrained functions in place of constrained function
TomAFrench
changed the title
unsafe blocks and passing unconstrained functions in place of constrained functionunsafe blocks and passing unconstrained functions in place of constrained functions
Execution Report
|
Compilation Report
|
Compilation Memory Report
|
Execution Memory Report
|
jfecher
approved these changes
Jan 3, 2025
|
@kashbrti can you address these failures in the noir libraries on monday? |
|
Would this be a breaking change? (It isn't currently indicated as one.) |
TomAFrench
changed the title
unsafe blocks and passing unconstrained functions in place of constrained functionsunsafe blocks and passing unconstrained functions in place of constrained functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ocks and passing unconstrained functions in place of constrained function
Description
Problem*
Resolves #6937
Summary*
These have been around for a long time now so I'm promoting this to an error.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.