feat!: disallow calling unconstrained functions outside of unsafe blocks and passing unconstrained functions in place of constrained functions

[TomAFrench]

…ocks and passing unconstrained functions in place of constrained function

Description

Problem*

Resolves #6937

Summary*

These have been around for a long time now so I'm promoting this to an error.

Additional Context

Documentation*

Check one:

• No documentation needed.
• Documentation included in this PR.
• [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt on default settings.

[github-actions]

Execution Report

Program	Execution Time	%
sha256_regression	0.100s	0%
regression_4709	0.001s	0%
ram_blowup_regression	0.584s	0%
rollup-root	0.105s	-1%
rollup-block-merge	0.105s	0%
rollup-base-public	1.430s	-1%
rollup-base-private	0.650s	-2%
private-kernel-tail	0.023s	-5%
private-kernel-reset	0.390s	-1%
private-kernel-inner	0.117s	0%

[github-actions]

Compilation Report

Program	Compilation Time
sha256_regression	1.358s
regression_4709	0.787s
ram_blowup_regression	15.060s
rollup-root	3.720s
rollup-block-merge	4.210s
rollup-base-public	29.700s
rollup-base-private	12.400s
private-kernel-tail	1.118s
private-kernel-reset	7.474s
private-kernel-inner	2.190s

[github-actions]

Compilation Memory Report

Program	Peak Memory
keccak256	78.50M
workspace	123.62M
regression_4709	422.91M
ram_blowup_regression	1.58G
rollup-base-public	2.55G
rollup-base-private	1.25G
private-kernel-tail	201.97M
private-kernel-reset	716.60M
private-kernel-inner	292.24M

[github-actions]

Execution Memory Report

Program	Peak Memory
keccak256	74.61M
workspace	123.78M
regression_4709	315.93M
ram_blowup_regression	512.47M
rollup-base-public	773.36M
rollup-base-private	424.92M
private-kernel-tail	182.01M
private-kernel-reset	255.59M
private-kernel-inner	215.19M

[TomAFrench]

@kashbrti can you address these failures in the noir libraries on monday?

[Savio-Sou]

Would this be a breaking change? (It isn't currently indicated as one.)