Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate ACVM without merging flakes #2773

Merged
merged 8 commits into from
Sep 21, 2023
Merged

chore: Migrate ACVM without merging flakes #2773

merged 8 commits into from
Sep 21, 2023

Conversation

kevaundray
Copy link
Contributor

Description

Problem*

Resolves

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@socket-security
Copy link

@TomAFrench TomAFrench mentioned this pull request Sep 21, 2023
5 tasks
@kevaundray kevaundray marked this pull request as ready for review September 21, 2023 14:11
@TomAFrench
Copy link
Member

Releases are likely broken in this due to no release-please setup changes

@kevaundray
Copy link
Contributor Author

Releases are likely broken in this due to no release-please setup changes

Yeah -- those changes would bump the version of Noir to 0.26, so I chose to do that separately and just have tests passing in this.

Only now realising that build-wasm takes 20-30 minutes :/

Copy link
Contributor

@kobyhallx kobyhallx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though releases are going to be broken, we can unblock bunch of changes and fix releases separately.

@TomAFrench TomAFrench added this pull request to the merge queue Sep 21, 2023
@TomAFrench TomAFrench removed this pull request from the merge queue due to a manual request Sep 21, 2023
@kevaundray kevaundray added this pull request to the merge queue Sep 21, 2023
Merged via the queue into master with commit 2e44988 Sep 21, 2023
27 checks passed
@kevaundray kevaundray deleted the kw/acvm-take2 branch September 21, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants