Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: trait inheritance #6252

Merged
merged 29 commits into from
Oct 11, 2024
Merged

feat: trait inheritance #6252

merged 29 commits into from
Oct 11, 2024

Commits on Oct 8, 2024

  1. Parse trait inheritance

    @asterite
    asterite committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    f2bd51f View commit details
    Browse the repository at this point in the history

  2. Make sure nargo_fmt doesn't break with trait inheritance

    @asterite
    asterite committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    be1ae07 View commit details
    Browse the repository at this point in the history

  3. Resolve trait parent bounds

    @asterite
    asterite committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    19016be View commit details
    Browse the repository at this point in the history

  4. Embed ResolvedTraitBound in TraitConstraint

    @asterite
    asterite committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    1bdbcf4 View commit details
    Browse the repository at this point in the history

  5. Solve trait bounds and lookup methods in parent types

    @asterite
    asterite committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    3937bd0 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Use filter_map

    @asterite
    asterite committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    95fa2c6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ab/trait-inheritance

    @asterite
    asterite committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    3b3565e View commit details
    Browse the repository at this point in the history

  3. Add assumed trait implementations for parent traits

    @asterite
    asterite committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    c65f865 View commit details
    Browse the repository at this point in the history

  4. Detect trait cycles

    @asterite
    asterite committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    57a538f View commit details
    Browse the repository at this point in the history

  5. Avoid looping forever in case there are cycles

    @asterite
    asterite committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    dc50605 View commit details
    Browse the repository at this point in the history

  6. Add a failing test for trait parents with generics

    @asterite
    asterite committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    4b65f50 View commit details
    Browse the repository at this point in the history

  7. Add a failing test for when a trait impl is missing a parent implemen… 

    …tation
    @asterite
    asterite committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    436f0be View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into ab/trait-inheritance

    @asterite
    asterite committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    38dd4e7 View commit details
    Browse the repository at this point in the history

  9. Make it work with generics

    @asterite
    asterite committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    c32803e View commit details
    Browse the repository at this point in the history

  10. Refactor

    @asterite
    asterite committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    3f8ae2d View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Check parent traits are implemented

    @asterite
    asterite committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9153f27 View commit details
    Browse the repository at this point in the history

  2. Add a test program

    @asterite
    asterite committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    810b87f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into ab/trait-inheritance

    @asterite
    asterite committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    6701a42 View commit details
    Browse the repository at this point in the history

  4. Correct way to format trait name with generics

    @asterite
    asterite committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    3278cc6 View commit details
    Browse the repository at this point in the history

  5. Correct parent check regarding generics

    @asterite
    asterite committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    5d79bd5 View commit details
    Browse the repository at this point in the history

  6. Add one more test

    @asterite
    asterite committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    7b34a78 View commit details
    Browse the repository at this point in the history

  7. Improve missing trait bound error message

    @asterite
    asterite committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    fdce653 View commit details
    Browse the repository at this point in the history

  8. Add some docs

    @asterite
    asterite committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    e7ea16f View commit details
    Browse the repository at this point in the history

  9. Simpler way to construct a Diagnostic

    @asterite
    asterite committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    8c5f3f4 View commit details
    Browse the repository at this point in the history

  10. Apply suggestions from code review 

    Co-authored-by: jfecher <[email protected]>
    @asterite @jfecher
    asterite and jfecher authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    81b7f3b View commit details
    Browse the repository at this point in the history

  11. Add supertrait and supertraits to cspell

    @asterite
    asterite committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f69a6ab View commit details
    Browse the repository at this point in the history

  12. Extract bind_ordered_generics

    @asterite
    asterite committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    216fc2e View commit details
    Browse the repository at this point in the history

  13. Remove more duplicated code

    @asterite
    asterite committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    566fce7 View commit details
    Browse the repository at this point in the history

  14. Add subtrait to cspell

    @asterite
    asterite committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    5ca1dee View commit details
    Browse the repository at this point in the history