-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: parse globals in SSA parser #7112
base: master
Are you sure you want to change the base?
Conversation
Compilation Report
|
Execution Report
|
Execution Memory Report
|
Compilation Memory Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for this PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10
.
Benchmark suite | Current: 434df26 | Previous: dd70845 | Ratio |
---|---|---|---|
rollup-root |
3.96 s |
3.566 s |
1.11 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
This reverts commit 252ee2b.
In the end I missed that you have to declare globals in every function using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10
.
Benchmark suite | Current: 434df26 | Previous: dd70845 | Ratio |
---|---|---|---|
private-kernel-tail |
0.022 s |
0.019 s |
1.16 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Done! Asking for a re-review just to check I got globals setting right. It seems we need to set:
|
Description
Problem
Resolves #7082
Summary
Additional Context
Documentation
Check one:
PR Checklist
cargo fmt
on default settings.