Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add BLS12_381 #7

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: Add BLS12_381 #7

wants to merge 7 commits into from
+882 −282

Conversation

iAmMichaelConnor
Copy link

Description

  • Add BLS12_381 curve params and tests.
  • Move curves into a curves/ dir.
  • Rename unconstrained functions to have __ prefix, because I think that convention from bignum really helps with readability.

Note: the evaluate_linear_expression test fails for both curves, but it also fails on master for bn254.

Problem*

Resolves

Summary*

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@iAmMichaelConnor iAmMichaelConnor changed the title Add BLS12_381 feat: Add BLS12_381 Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iAmMichaelConnor