Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed typecast #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Pluckerpluck
Copy link

Pull Request for Issue #85

For the love of all that is good, test this first! I cannot, and thus I am just running with what the javadocs + error has told me.

If it fails, try casting to (SpannableString) instead

@nolanlawson
Copy link
Owner

This makes me very nervous. What device/Android version were you testing on where you got a failed type cast?

@nolanlawson
Copy link
Owner

Oh wait nevermind, I saw this PR before the issue describing it. LGTM, need to test tho. Thanks a bunch!

Copy link

@GPSHansl GPSHansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitly a valid code change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants