-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix version-info for 8.9.0 and drop release #11
base: master
Are you sure you want to change the base?
Conversation
Side note, rpmsodiff show that library ABI isn't compatible (symbols are removed), so there is indeed a need to change the SONAME, but it wasn't done in the 8.9.0 autotools release.
|
We have no automatic testing on PRs? |
This will lead to a libcryptopp.so.9 SONAME and libcryptopp.so.9.0.0 library.
f866c60
to
7161088
Compare
Seems like I've pushed the wrong patch, force-pushed. Alternative is more likely to use libcryptopp-8.9.0.so.0 (for 8.9.0) and rely on the same variable that defines the major version. But this isn't the usual way to define the SONAME on linux. |
This will lead to a libcryptopp.so.9 SONAME and libcryptopp.so.9.0.0 library.