NooBaa nsfs service showing Error No disk candidates found at generate entropy due to unsupported /dev/nvme0 devices

[ramya-c3]

Environment info

• NooBaa Version: 5.17.0
• Platform: Standalone

Actual behavior

[nsfs/465779] [LOG] CONSOLE:: generate_entropy: error
Error: No disk candidates found at generate_entropy (/usr/local/noobaa-core/src/util/nb_native.js:138:27) at async init_rand_seed (/usr/local/noobaa-core/src/util/nb_native.js:63:5)
Dec 12 19:00:24 stor107.ete14.res.ibm.com node[465779]: Dec-12 19:00:24.636 [nsfs/465779] [LOG] CONSOLE:: generate_entropy: error Error: No disk candidates found

Expected behavior

1.generate_entropy should be able to handle nvme devices, so that NooBaa nsfs service starts without error.

Steps to reproduce

The problem can be mitigated by adding /dev/dasda to
line 122 in /usr/local/noobaa-core/src/util/nb_native.js

" for (disk of ['/dev/sda', '/dev/vda', '/dev/xvda', '/dev/dasda','/dev/nvme0']) {"

and restart NooBaa nsfs service

More information - Screenshots / Logs / Other output

[rkomandu]

@romayalon , this is similar to the #7982

[rkomandu]

@ramya-c3 , could you work with Romy and if needed check the fix, as we have tried manually patching in the 5.15.6 on ECE cluster yday w/r/t nvme disks.

@romayalon , please let Ramya know about the upstream if needs to be tested. However as mentioned over slack there is no ECE cluster we have at hand with nvme drives.

[ramya-c3]

@romayalon This issue is not resolved please add /dev/nvme0n1 should be added instead of nvme0 alone. Is there a way that we can have wildcard character so we can have any number of characters post nvme?

[rkomandu]

IMO, we need to understand what is the role of this, can @romayalon explain the same.. @ramya-c3 if possible can you post the lsblk command of ECE cluster for her reference

[romayalon]

@rkomandu @ramya-c3 this code was written 8 years ago and its purpose is to make sure we generate highly random encryption keys. Attaching here a link to a detailed github issue that Guy opened for explaining the purpose. @guymguym might be able to share more details.
@ramya-c3 Can you run the new code on a machine with '/dev/nvme0' for checking my code?
Also, please check what are the optional disks in ECE cluster instead of doing iterations.

[shirady]

@guymguym Do you know if this part of the code must be hard-coded?
I thought that for future cases, maybe we can add it as a property in the config.json?

[romayalon]

@rkomandu @ramya-c3 I'm reverting /dev/nvme0 for now, please check what are the optional disks in ECE cluster so we can do this change properly in the next PR