Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC | generate_entropy() - remove /dev/nvme0 from the supported devices list #8614

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Dec 19, 2024

Explain the changes

  1. Removed /dev/nvme0 from the supported devices list in generate_entropy(), revert of NC | generate_entropy() - add /dev/nvme0 disks to the supported devices #8600

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

@romayalon romayalon force-pushed the romy-disk-candidate-nvme0 branch from 6954b1a to 50367ed Compare December 19, 2024 14:20
@romayalon romayalon changed the title NC | generate_entropy() - add /dev/nvme0n1 disks to the supported devices NC | generate_entropy() - add /dev/nvme0n1 and /dev/nvme1n1 disks to the supported devices Dec 19, 2024
@romayalon
Copy link
Contributor Author

@rkomandu @ramya-c3 can you pls make sure these are the disks you need?
/dev/nvme0n1, /dev/nvme1n1

@romayalon romayalon requested a review from shirady December 19, 2024 14:22
Copy link
Contributor

@shirady shirady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romayalon romayalon force-pushed the romy-disk-candidate-nvme0 branch 2 times, most recently from 3e45a77 to 2df9df0 Compare December 19, 2024 16:11
@romayalon romayalon force-pushed the romy-disk-candidate-nvme0 branch from 2f1cff2 to d292002 Compare December 23, 2024 13:40
@romayalon romayalon changed the title NC | generate_entropy() - add /dev/nvme0n1 and /dev/nvme1n1 disks to the supported devices NC | generate_entropy() - remove /dev/nvme0 from the supported devices list Dec 23, 2024
@romayalon
Copy link
Contributor Author

@shirady I'm reverting /dev/nvme0 for now

@romayalon romayalon merged commit df9f8b2 into noobaa:master Dec 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants