Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NC | generate_entropy() - add /dev/nvme0 disks to the supported devices #8600

Merged
merged 1 commit into from
Dec 17, 2024
Merged

NC | generate_entropy() - add /dev/nvme0 disks to the supported devices #8600

merged 1 commit into from
Dec 17, 2024

Conversation

romayalon
Copy link
Contributor

Explain the changes

  1. Add /dev/nvme0 disks to the supported devices (as the suggested on the bug) for not failing generate_entropy()

Issues: Fixed #xxx / Gap #xxx

  1. Fixed NooBaa nsfs service showing Error No disk candidates found at generate entropy due to unsupported /dev/nvme0 devices #8598

Testing Instructions:

  1. Start NooBaa service on a machine with /dev/nvme0 device, check generate_entropy successful
  • Doc added/updated
  • Tests added

@romayalon romayalon force-pushed the romy-disk-candidate-nvme0 branch from 1fdec60 to 8f96a39 Compare December 17, 2024 10:38
@romayalon romayalon merged commit 802ccda into noobaa:master Dec 17, 2024
10 checks passed
@romayalon romayalon mentioned this pull request Dec 23, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackyalbo jackyalbo jackyalbo approved these changes

@shirady shirady Awaiting requested review from shirady

@naveenpaul1 naveenpaul1 Awaiting requested review from naveenpaul1

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
2 participants
@romayalon @jackyalbo