Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | noobaa-cli Help format Update #8581

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

naveenpaul1
Copy link
Contributor

@naveenpaul1 naveenpaul1 commented Dec 5, 2024

Explain the changes

  1. Noobaa CLI help output updated to below format for all the CLI commnds
node src/cmd/manage_nsfs upgrade --help 2>/dev/null
Help:

    'upgrade' noobaa-core command will initiate version upgrade and also return the upgrade status or history.

Usage:

    noobaa-cli upgrade <action> [flags]

List of actions supported:

    start
    status
    history
    

Issues: Fixed #xxx / Gap #xxx

  1. NC | noobaa-cli Help Needs Update in action Part #8565

Testing Instructions:

  1. run help command for all the CLI combinations.

Note : Doc is not updated for the MD5 changes

  • Doc added/updated
  • Tests added

This PR fixes only formatting issues, to update help doc a new issue is created. : #8595

@romayalon
Copy link
Contributor

@naveenpaul1 when you put the issue under the fixes section you must have 'Fixed' keyword before so it'll close the issue automatically.
@shirady please review this PR, thanks in advance

@naveenpaul1 naveenpaul1 linked an issue Dec 5, 2024 that may be closed by this pull request
Copy link
Contributor

@shirady shirady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added comments and also mentioned other team member as I think we can improve and make it more accurate.

src/manage_nsfs/manage_nsfs_help_utils.js Outdated Show resolved Hide resolved
src/manage_nsfs/manage_nsfs_help_utils.js Outdated Show resolved Hide resolved
src/manage_nsfs/manage_nsfs_help_utils.js Show resolved Hide resolved
src/manage_nsfs/manage_nsfs_help_utils.js Outdated Show resolved Hide resolved
src/manage_nsfs/manage_nsfs_help_utils.js Show resolved Hide resolved
src/manage_nsfs/manage_nsfs_help_utils.js Show resolved Hide resolved
src/manage_nsfs/manage_nsfs_help_utils.js Show resolved Hide resolved
src/manage_nsfs/manage_nsfs_help_utils.js Show resolved Hide resolved
src/manage_nsfs/manage_nsfs_help_utils.js Outdated Show resolved Hide resolved
src/manage_nsfs/manage_nsfs_help_utils.js Show resolved Hide resolved
Copy link
Contributor

@shirady shirady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naveenpaul1 naveenpaul1 merged commit 48006db into noobaa:master Dec 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NC | noobaa-cli Help Needs Update in action Part
3 participants