Added a check for duplicate Id in bucket lifecycle rules

[achouhan09]

Explain the changes

1. Added a check for duplicate Id in bucket lifecycle rules.

Issues: Fixed #xxx / Gap #xxx

1. Fixed: NSFS | S3 | Lifecycle: two rules with the same ID are accepted #8550

Testing Instructions:

• Tests added

[romayalon]

Hey @achouhan09

1. Can you please link to the Issues section the bug you are fixing?
2. Please add tests
3. Are you following S3 protocol by throwing InvalidArgument error? please make sure this is the expected error code

[achouhan09]

Hi @romayalon
Added issue link and tests. Thanks

check this for the AWS s3 protocol. I think InvalidArgument error suits here.

[shirady]

Hi @romayalon Added issue link and tests. Thanks

check this for the AWS s3 protocol. I think InvalidArgument error suits here.

Could you test it in AWS and attach the results here?

[achouhan09]

Hi @romayalon Added issue link and tests. Thanks
check this for the AWS s3 protocol. I think InvalidArgument error suits here.

Could you test it in AWS and attach the results here?

[shirady]

replied to comment
@achouhan09 does noobaa use the same error message?
I mean this: "Rule ID must be unique. Found same ID for more than one rule"

[achouhan09]

replied to comment @achouhan09 does noobaa use the same error message? I mean this: "Rule ID must be unique. Found same ID for more than one rule"

For NooBaa, we will only get InvalidArgument error and no error msg on the command line. But we can check the error logs in the endpoint pod which is similar to what you are referring. Below is the NooBaa error:

An error occurred (InvalidArgument) when calling the PutBucketLifecycleConfiguration operation: Invalid Argument

[achouhan09]

replied to comment @achouhan09 does noobaa use the same error message? I mean this: "Rule ID must be unique. Found same ID for more than one rule"

@shirady update the error msg. Thanks