bucket notification - ignore failure if notification was removed #8709
+49
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspandey
reviewed
Jan 22, 2025
| if (this.nc_config_fs) { | ||
| bucket = await this.nc_config_fs.get_bucket_by_name(notif.meta.bucket); | ||
| } else { | ||
| const system = this.system_store.data.systems[0]; |
There was a problem hiding this comment.
Line number 71 and 72 suggest that system could be null. So better check it here also?
There was a problem hiding this comment.
If system is null, then _can_run() will return false and bg worker will not run (and we will not get to handle_failed_notification() where I don't check is system is not null).
| if (send_promise) send_promises.push(send_promise); | ||
| if (send_promises.length > this.batch_size) { | ||
| await Promise.all(send_promises); | ||
| send_promises = []; | ||
| } | ||
| } catch (err) { | ||
| dbg.error("Failed to notify. err = ", err, ", str =", str); | ||
| await failure_append(str); | ||
| //re-write the failed notification if it's still configured on the bucket | ||
| if (notif) { |
There was a problem hiding this comment.
No need of this check.
"notif" will not be null at this point. If it could be, then we should have checked it before line no 124.
There was a problem hiding this comment.
notif can be null in case json parsing fails (currently line 123).
If json parsing is ok, notif will not be null on 124 and forward.
aspandey
approved these changes
Jan 23, 2025
alphaprinz
force-pushed
the
notif_ignore
branch
from
4825980 to
f5817e1
Compare
Signed-off-by: Amit Prinz Setter <[email protected]>
alphaprinz
force-pushed
the
notif_ignore
branch
from
f5817e1 to
7167ef2
Compare
alphaprinz
added a commit
to alphaprinz/noobaa-core
that referenced
this pull request
Jan 23, 2025
…baa#8709) Signed-off-by: Amit Prinz Setter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Now they are re-written only if they are still configured on the bucket.
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: