Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP add vendor Id to some boards #162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nandub
Copy link
Contributor

@nandub nandub commented Jul 17, 2018

The week before last on your twitch live stream you mention that the library may need to start looking at vendorId because of the collision you found from one of the boards, which I cannot remember which one.

This work is a WIP not sure if it can be merge as is, I only updated the boards.js file. I'm not familiar with the library to be able to make proper changes to implement the vendorId.

Maybe others can start adding vendorId and productId pairs on this pull request for the rest of the boards. Boards without matching vendorId I used 0x0000 as a place holder for it.

The following list of boards have vendorIds so far:

  • uno (includes Sparkfun Redboard)
  • micro
  • leonardo,
  • mega
  • yun
  • esplora
  • imuduino
  • arduboy
  • feather
  • little-bits
  • blend-micro
  • nano
  • duemilanove168
  • duemilanove328
  • tinyduino
  • adk
  • sf-pro-micro
  • pro-mini
  • qduino
  • pinoccio
  • lilypad-usb
  • circuit-playground-classic
  • zumjunior
  • zumcore2
  • bqZum

I used the Arduino IDE provided boards.txt to get the list of vendorId and productId for each known boards.

@coveralls
Copy link

coveralls commented Jul 17, 2018

Coverage Status

Coverage remained the same at 46.689% when pulling ba35b63 on nandub:arduino-core-vendorid into 4c88107 on noopkat:master.

@nandub
Copy link
Contributor Author

nandub commented Jul 22, 2018

The vendorId with 0x0000 is a place holder until we find the real vendorId.

@noopkat
Copy link
Owner

noopkat commented Jul 22, 2018

Hi @nandub!

Thank you SO MUCH for getting this work started. I really appreciate this, as I remember how long it took for me to track down all of the product id's originally when I wrote this.

I'll try to set aside time to add some more, and for anyone else reading this we'd love your contributions as well! 🌟

bitmoji

@noopkat noopkat added the WIP label Jul 22, 2018
@nandub nandub force-pushed the arduino-core-vendorid branch from 8362d34 to 6611a94 Compare October 16, 2018 00:19
@nandub
Copy link
Contributor Author

nandub commented Oct 16, 2018

The style of the boards.js completely changed, so this pull request was not applying cleanly, it should now apply without conflicts. Plus added the sparkfun redboard which is compatible with Arduino Uno.

@nandub nandub force-pushed the arduino-core-vendorid branch from 6611a94 to 4fb4ead Compare March 11, 2019 01:52
@nandub nandub force-pushed the arduino-core-vendorid branch from 4fb4ead to e8f0cc1 Compare May 13, 2019 00:54
@nandub nandub force-pushed the arduino-core-vendorid branch from e8f0cc1 to a74dc03 Compare January 16, 2020 16:19
@nandub nandub force-pushed the arduino-core-vendorid branch from a74dc03 to 698deff Compare January 27, 2020 22:22
@nandub nandub force-pushed the arduino-core-vendorid branch from 698deff to 06a2673 Compare May 19, 2020 20:56
@nandub nandub force-pushed the arduino-core-vendorid branch from 06a2673 to ba35b63 Compare February 9, 2021 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants