Prevent recursion #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial motivation:
If the connection to the MySQL server is unstable, Nimda might lose connection to the server and attempts to re-run the query after a reconnecting to the server. Given the unstable connection, it might fail again to execute the query. Rinse and repeat, it will descend into recursion breaking Nimda.
What I have done:
Added a counter for the reconnection attempts (actually it counts the failed queries until one succeeds but it boils down to the reconnection attempts) and a
trigger_errorafternfailed attempts (currently 5).Request for comments: Always (what else ;) ) I picked the severity
E_USER_WARNINGbased on the other calls oftrigger_error