Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove common- beanutils and spring-webmvc dependencies #53

Merged
merged 2 commits into from
Sep 23, 2024
Merged

chore: Remove common- beanutils and spring-webmvc dependencies #53

merged 2 commits into from
Sep 23, 2024

Conversation

melbeltagy
Copy link
Contributor

  • Replacing commons-beanutils usage with spring boot class to remove it from dependencies
  • Spring-WebMVC dependency was added to fix security issue. Latest Spring Boot (v.3.3.4) is using the same version by default (so no need to explicitly declare it)

Refs: XRDCAT-28

@melbeltagy melbeltagy requested review from a team and andresrosenthal and removed request for a team September 19, 2024 21:31
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

Job Summary for Gradle

X-Road-Catalog tests :: BuildAndTest
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
x-road-catalog
buildEnvironment xroad-catalog-persistence:buildEnvironment…
 8.10 ✅ Build Scan not published
x-road-catalog build 8.10 ✅ Build Scan not published

@melbeltagy melbeltagy merged commit 3085573 into develop Sep 23, 2024
3 checks passed
@melbeltagy melbeltagy deleted the remove-commons-beanutils-and-webmvc-dependency branch September 23, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresrosenthal andresrosenthal andresrosenthal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@melbeltagy @andresrosenthal